test: Add coverage for healthcheck server #37
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
| if got := w.Code; got != tt.expectedStatus { | ||
| t.Errorf("handleHealthCheck() status = %v, want %v", got, tt.expectedStatus) | ||
| } |
There was a problem hiding this comment.
This comes a bit late to the party since most of the tests have already been written, but maybe we should use a package like github.com/stretchr/testify/assert to make these assertions clearer? E.g. this would then be
| if got := w.Code; got != tt.expectedStatus { | |
| t.Errorf("handleHealthCheck() status = %v, want %v", got, tt.expectedStatus) | |
| } | |
| assert.Equal(t, w.Code, tt.expectedStatus, "wrong handleHealthCheck() status") |
There was a problem hiding this comment.
Good idea, I'll start using testify from now on and maybe later we can revisit older tests!
| if err := json.NewDecoder(w.Body).Decode(&response); err != nil { | ||
| t.Errorf("failed to decode response body: %v", err) | ||
| } |
There was a problem hiding this comment.
And this would be
| if err := json.NewDecoder(w.Body).Decode(&response); err != nil { | |
| t.Errorf("failed to decode response body: %v", err) | |
| } | |
| err := json.NewDecoder(w.Body).Decode(&response); | |
| assert.NoError(t, err) |
| name: "returns default port when env var is negative", | ||
| envPort: "-1", | ||
| expectedPort: defaultPort, |
There was a problem hiding this comment.
Wonder if we should throw instead if an invalid port is configured?
There was a problem hiding this comment.
Refactored to move this to the new config style from n8n-io/n8n#8446
https://linear.app/n8n/issue/PAY-2247/write-tests-for-launcher