Revert "rename constant to match error described in value"

This reverts commit b5bf9d8.
n8n-io · Feb 5, 2024 · 23c11cc · 23c11cc
1 parent b5bf9d8
commit 23c11cc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/constants.js b/src/constants.js
@@ -27,7 +27,7 @@ const ERRORS = {
   TYPE_NOT_FOUND: `Failed to find \`type\` in PR title. Expected one of ${displayTypes}`,
   INVALID_TYPE: `Unknown \`type\` in PR title. Expected one of ${displayTypes}`,
   INVALID_SCOPE: `Unknown \`scope\` in PR title. Expected one of ${displayScopes} or \`<displayName> Node\``,
-  UPPERCASE_INITIAL_IN_SUBJECT: "First char of subject must be uppercase",
+  LOWERCASE_INITIAL_IN_SUBJECT: "First char of subject must be uppercase",
   FINAL_PERIOD_IN_SUBJECT: "Subject must not end with a period",
   NO_PRESENT_TENSE_IN_SUBJECT: "Subject must use present tense",
   SKIP_CHANGELOG_NOT_IN_FINAL_POSITION: `\`${NO_CHANGELOG}\` must be located at the end of the subject`,

diff --git a/src/validatePrTitle.js b/src/validatePrTitle.js
@@ -50,7 +50,7 @@ async function validatePrTitle(title) {
   const { subject } = match.groups;
 
   if (startsWithLowerCase(subject)) {
-    issues.push(ERRORS.UPPERCASE_INITIAL_IN_SUBJECT);
+    issues.push(ERRORS.LOWERCASE_INITIAL_IN_SUBJECT);
   }
 
   if (endsWithPeriod(subject)) {

diff --git a/src/validatePrTitle.test.js b/src/validatePrTitle.test.js
@@ -105,7 +105,7 @@ describe("subject", () => {
     const issues = await validate("feat(core): implement feature");
     expect(issues)
       .toHaveLength(1)
-      .toContain(ERRORS.UPPERCASE_INITIAL_IN_SUBJECT);
+      .toContain(ERRORS.LOWERCASE_INITIAL_IN_SUBJECT);
   });
 
   test("Validation should fail for final period in subject", async () => {