Skip to content

Commit

Permalink
optimize unit test naming
Browse files Browse the repository at this point in the history
  • Loading branch information
tinohager committed Jan 21, 2025
1 parent af233b7 commit 98de5ef
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ public sealed class SelectorTest
[DataRow("selector2")]
[DataRow("google")]
[DataTestMethod]
public void TryParse_ValidVersionDkimHeaderString_ReturnsTrueAndPopulatesDataFragment(string selector)
public void TryParse_ValidSelector_ReturnsTrueAndPopulatesDataFragment(string selector)
{
var dkimHeader = $"v=1; a=rsa-sha256; d=domain.com; s={selector}; h=message-id:from; bh=testbodyhash=; b=signaturedata";

Expand All @@ -20,7 +20,7 @@ public void TryParse_ValidVersionDkimHeaderString_ReturnsTrueAndPopulatesDataFra

[DataRow("verylongandinvalidselectorverylongandinvalidselectorverylongandinvalidselector")]
[DataTestMethod]
public void TryParse_InvalidVersionDkimHeaderString_ReturnsTrueAndPopulatesDataFragment(string selector)
public void TryParse_InvalidSelector_ReturnsTrueAndPopulatesDataFragment(string selector)
{
var dkimHeader = $"v=1; a=rsa-sha256; d=domain.com; s={selector}; h=message-id:from; bh=testbodyhash=; b=signaturedata";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ public sealed class VersionTest
[DataRow("2")]
[DataRow("3")]
[DataTestMethod]
public void TryParse_ValidVersionDkimHeaderString_ReturnsTrueAndPopulatesDataFragment(string version)
public void TryParse_ValidVersion_ReturnsTrueAndPopulatesDataFragment(string version)
{
var dkimHeader = $"v={version}; a=rsa-sha256; d=domain.com; s=myselector; h=message-id:from; bh=testbodyhash=; b=signaturedata";

Expand All @@ -21,7 +21,7 @@ public void TryParse_ValidVersionDkimHeaderString_ReturnsTrueAndPopulatesDataFra
[DataRow("a")]
[DataRow("a1")]
[DataTestMethod]
public void TryParse_InvalidVersionDkimHeaderString_ReturnsTrueAndPopulatesDataFragment(string version)
public void TryParse_InvalidVersion_ReturnsTrueAndPopulatesDataFragment(string version)
{
var dkimHeader = $"v={version}; a=rsa-sha256; d=domain.com; s=myselector; h=message-id:from; bh=testbodyhash=; b=signaturedata";

Expand Down

0 comments on commit 98de5ef

Please sign in to comment.