Skip to content

Commit

Permalink
fix: remove commented-out removeQuotes() function
Browse files Browse the repository at this point in the history
  • Loading branch information
Pragadesh-45 authored and naman-bruno committed Jan 17, 2025
1 parent ec0b49e commit e6f271c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
10 changes: 0 additions & 10 deletions packages/bruno-js/src/sandbox/quickjs/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@ const toNumber = (value) => {
return Number.isInteger(num) ? parseInt(value, 10) : parseFloat(value);
};

// const removeQuotes = (str) => {
// if ((str.startsWith('"') && str.endsWith('"')) || (str.startsWith("'") && str.endsWith("'"))) {
// return str.slice(1, -1);
// }
// return str;
// };

const executeQuickJsVm = ({ script: externalScript, context: externalContext, scriptType = 'template-literal' }) => {
if (!externalScript?.length || typeof externalScript !== 'string') {
Expand All @@ -44,8 +38,6 @@ const executeQuickJsVm = ({ script: externalScript, context: externalContext, sc
if (externalScript === 'null') return null;
if (externalScript === 'undefined') return undefined;

// This is commented out as part of the fix for #3758
// externalScript = removeQuotes(externalScript);

const vm = QuickJSSyncContext;

Expand Down Expand Up @@ -95,8 +87,6 @@ const executeQuickJsVmAsync = async ({ script: externalScript, context: external
if (externalScript === 'null') return null;
if (externalScript === 'undefined') return undefined;

// This is commented out as part of the fix for #3758
// externalScript = removeQuotes(externalScript);

try {
const module = await newQuickJSWASMModule();
Expand Down
10 changes: 0 additions & 10 deletions packages/bruno-js/src/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,16 +85,6 @@ const evaluateJsTemplateLiteral = (templateLiteral, context) => {
return undefined;
}

// This is commented out as part of the fix for #3758
// if (templateLiteral.startsWith('"') && templateLiteral.endsWith('"')) {
// return templateLiteral.slice(1, -1);
// }

// This is commented out as part of the fix for #3758
// if (templateLiteral.startsWith("'") && templateLiteral.endsWith("'")) {
// return templateLiteral.slice(1, -1);
// }

if (!isNaN(templateLiteral)) {
const number = Number(templateLiteral);
// Check if the number is too high. Too high number might get altered, see #1000
Expand Down

0 comments on commit e6f271c

Please sign in to comment.