Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to rust edition 2021 + best practices. #118

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Bump to rust edition 2021 + best practices. #118

merged 1 commit into from
Nov 24, 2023

Conversation

Grinkers
Copy link
Collaborator

The async feature has been removed.
The async example is now using stable async/futures.

Relevant discussions:
#116
#117

I'm not sure how many people use this crate, but I think this might be one of the last big breaking changes for standard features. A 0.18.0 release might be a good idea. An added note about an org change (#109) from 0.19.0 might be a good idea.

The `async` feature has been removed.
The async example is now using stable async/futures.
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fe6b043) 71.38% compared to head (cffc902) 71.53%.

Files Patch % Lines
src/edn/utils/index.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   71.38%   71.53%   +0.15%     
==========================================
  Files           8        8              
  Lines         940      938       -2     
==========================================
  Hits          671      671              
+ Misses        269      267       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Grinkers Grinkers marked this pull request as ready for review November 24, 2023 06:23
Copy link
Owner

@naomijub naomijub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will bump to 0.18
We should decide the org name

@Grinkers Grinkers merged commit d852751 into master Nov 24, 2023
5 checks passed
@Grinkers Grinkers deleted the 2021 branch November 24, 2023 06:49
@Grinkers
Copy link
Collaborator Author

@naomijub hold that release for #119
hopefully the last breaking change I suggest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants