-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The crate is now no_std
with no breaking changes with default-features.
#132
Conversation
2dd4371
to
fc1f68f
Compare
Rebased and cleaned. Still waiting on 125. |
Update, it's running on real hardware! Fully working project here It's running on an $0.80 processor with sets. Full deserialization and serialization. I'm running it on custom hardware, but it should work on a https://www.raspberrypi.com/products/raspberry-pi-pico/ hello edn {:bar 9042.123, :count 1, :foo #{1, 2, 3, 42, }, }
hello edn {:bar 9042.123, :count 2, :foo #{1, 2, 3, 42, }, }
hello edn {:bar 9042.123, :count 3, :foo #{1, 2, 3, 42, }, }
hello edn {:bar 9042.123, :count 4, :foo #{1, 2, 3, 42, }, }
hello edn {:bar 9042.123, :count 5, :foo #{1, 2, 3, 42, }, } output looks like this via serial |
Marked as ready, although it has conflicts with #125. It would be nice to get that done first, then I can resolve conflicts that pop up. @evaporei Additionally, a macro sanity check with I will benchmark and write details about memory usage after #123, which will include an optimization pass. btw it should also be easy to compile to wasm now too, if anybody wants to play with that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Actually, |
(Edited a second time, after running on real hardware)
This ended up being a lot easier than I expected. The one breaking change is anybody using
--no-default-features
(likely only me, introduced only recently withsets
) probably wants to add--features std
.https://github.com/Grinkers/pico-edn/blob/main/pico-edn/src/lib.rs
It runs on real hardware!
dev-dependencies
rely on std, so things get really weird with examples. We couldn't run them anyway, so I think examples should live in a separate repo. Running tests and test coverage is also likely going to be really hard/impractical. We still test everything, logically, with a std env though.I'll probably write a tiny little lisp that controls some hardware via s-expressions over serial as a more complete example for the org.
I think this is ready. Any thoughts?