-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added to body assembly and PCB wiring documentation #498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are great additions, thank you! I've added a few minor comments, otherwise this is ready to get added in.
electrical/pcb/README.md
Outdated
|
||
Use this diagram to determine to wire things together: | ||
Use these diagrams to determine how to wire things together: | ||
|
||
TODO: add diagram of board / power supply / external switch / multimeter wiring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: add diagram of board / power supply / external switch / multimeter wiring |
I believe your image addresses this TODO, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I believe you right. These look good.
…ectrical instructions. fixed a few other minor things
I'm going to close this pull request. I'll work on another one with the figure numbers corrected. |
I believe I closed this by accident, so I'm reopening it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks for this. Will merge this in!
Added two images and accompanying text for the main body assembly and PCB wiring. Main body image is for the 'bearing support structures' and PCB wiring shows the power headers connected to end components.