Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added to body assembly and PCB wiring documentation #498

Merged
merged 7 commits into from
Jan 3, 2025

Conversation

igillespie
Copy link
Contributor

Added two images and accompanying text for the main body assembly and PCB wiring. Main body image is for the 'bearing support structures' and PCB wiring shows the power headers connected to end components.

Copy link
Collaborator

@Achllle Achllle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great additions, thank you! I've added a few minor comments, otherwise this is ready to get added in.


Use this diagram to determine to wire things together:
Use these diagrams to determine how to wire things together:

TODO: add diagram of board / power supply / external switch / multimeter wiring
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TODO: add diagram of board / power supply / external switch / multimeter wiring

I believe your image addresses this TODO, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe you right. These look good.

electrical/pcb/README.md Outdated Show resolved Hide resolved
electrical/pcb/README.md Outdated Show resolved Hide resolved
…ectrical instructions. fixed a few other minor things
@igillespie
Copy link
Contributor Author

I'm going to close this pull request. I'll work on another one with the figure numbers corrected.

@igillespie igillespie closed this Dec 18, 2024
@igillespie
Copy link
Contributor Author

I believe I closed this by accident, so I'm reopening it.

@igillespie igillespie reopened this Dec 18, 2024
Copy link
Collaborator

@Achllle Achllle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for this. Will merge this in!

@Achllle Achllle merged commit 7c3a585 into nasa-jpl:master Jan 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants