Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-9270: As CMR DevOps I want CMR services to abstractly create a DB connection #1965

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

TylerHeald1
Copy link
Contributor

No description provided.

@zimzoom
Copy link
Contributor

zimzoom commented Aug 29, 2023

I like this approach. I do kind of wonder whether this should merge into a feature branch ala feature/db-abstraction , since:

  • it is a very small piece of what will ultimately be a large refactor, which has not been fully designed yet
  • it would make easier to incorporate this change with the other very large pending database code change
  • it would make it easier for devs on other teams to review all the pieces in their context
  • it would help keep CMR git history tidy (which some have voiced lately has been getting painful)

EDIT -- after team discussion, we elected not to pursue this path because it does not match the wider workflow of the org.

@TylerHeald1 TylerHeald1 merged commit 952818d into master Aug 31, 2023
1 check passed
@TylerHeald1 TylerHeald1 deleted the CMR-9270 branch September 21, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants