CMR-9409: Added validation to prevent drafts from being associated. #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxu123
changed the title
system-int-test/test/cmr/system_int_test/search/generic_association_test.clj
Show resolved
Hide resolved
| @@ -481,7 +481,7 @@ | |||
| (let [concept-ids (concat [(:concept-id concept)] (map :concept-id associations)) | |||
| concept-types (map #(concepts/concept-id->type %) concept-ids) | |||
| supported-concept-types (set (concat [:collection :variable :service :tool] | |||
| (concepts/get-generic-concept-types-array))) | |||
| concepts/get-generic-non-draft-concept-types-array)) | |||
There was a problem hiding this comment.
We should probably add just a sentence to the Search api doc under the Associate any concept section like: note: draft records can only be associated to other draft records
There was a problem hiding this comment.
Draft records cannot be associated to other draft records.
There was a problem hiding this comment.
I do think its worthwhile to add that as a note in that section to avoid a later confusion just something like: Note: Draft records cannot be associated to any concepts.
eereiter
approved these changes
Sep 19, 2023
eudoroolivares2016
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.