Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-10173: Update XML > UMM mapping for DatasetProgress > CollectionProgress #2187

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

jmaeng72
Copy link
Contributor

@jmaeng72 jmaeng72 commented Nov 4, 2024

Overview

What is the feature/fix?

XML DIF10 still not mapping correctly to UMM JSON Collection Progress

What is the Solution?

Add the new enums to the correct collection progress map

What areas of the application does this impact?

List impacted areas.

Checklist

  • I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@jmaeng72 jmaeng72 self-assigned this Nov 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.22%. Comparing base (03938d0) to head (4eb55e8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2187      +/-   ##
==========================================
- Coverage   58.22%   58.22%   -0.01%     
==========================================
  Files        1055     1055              
  Lines       71010    71010              
  Branches     2024     2026       +2     
==========================================
- Hits        41347    41345       -2     
  Misses      27773    27773              
- Partials     1890     1892       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmaeng72 jmaeng72 changed the title CMR_10173: Update XML > UMM mapping for DatasetProgress > CollectionProgress CMR-10173: Update XML > UMM mapping for DatasetProgress > CollectionProgress Nov 5, 2024
@jmaeng72 jmaeng72 merged commit dd8ee96 into master Nov 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants