-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUMULUS-3847: Remove any remaining ES indexing functions and tests #3897
base: feature/es-phase-2
Are you sure you want to change the base?
Changes from all commits
bace254
a71fb8a
f405651
90683a9
c6f3cee
5801e86
2b6cb9f
af84342
57df04d
8034a5d
596ab38
5317873
a1a5183
94b1b25
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,7 +94,7 @@ async function applyWorkflowToGranules({ | |
* @param {number} [payload.concurrency] | ||
* granule concurrency for the bulk deletion operation. Defaults to 10 | ||
* @param {Object} [payload.query] - Optional parameter of query to send to ES | ||
* @param {string} [payload.index] - Optional parameter of ES index to query. | ||
* @param {string} [payload.index] - Optional parameter of ES index (metrics) to query. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Meaning we're checking the Cloud Metrics ES index? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, my understanding of why we need to keep the ES related functionality is that for some of the granules and bulk operations it will still query Cloud Metrics for data. I don't feel like totally understand how it all ties together, but that is what is mentioned in code and what I was informed of. So I thought it would be helpful to clarify as much as possible that the ES indexing and querying is going to Cloud Metrics and that's why it is staying around and not being removed as part of ES removal. |
||
* Must exist if payload.query exists. | ||
* @param {Object} [payload.granules] - Optional list of granule unique IDs to bulk operate on | ||
* e.g. { granuleId: xxx, collectionID: xxx } | ||
|
@@ -179,7 +179,7 @@ async function bulkGranuleDelete( | |
* @param {Object} [payload.meta] - Optional meta to add to workflow input | ||
* @param {string} [payload.queueUrl] - Optional name of queue that will be used to start workflows | ||
* @param {Object} [payload.query] - Optional parameter of query to send to ES | ||
* @param {string} [payload.index] - Optional parameter of ES index to query. | ||
* @param {string} [payload.index] - Optional parameter of ES index (metrics) to query. | ||
* Must exist if payload.query exists. | ||
* @param {Object} [payload.granules] - Optional list of granule unique IDs to bulk operate on | ||
* e.g. { granuleId: xxx, collectionID: xxx } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
placeholder, I'm still making sure I've captured everything. will make sure this is filled out when I'm fairly certain