-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nasa/nos3#286] Updates to time driver to avoid crash when slowed #392
Conversation
…000 real microseconds per tick;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, stops at 0.12 as expected, and doesn't crash. Still was some weird behavior when I increased speed by too much, but allowed me to slow back down without crashing as well, so looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also found it to work as intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found to work as intended unless rapidly sped up then slowed down in which case decimal values change the lower limit to .13 and then crashes if lowered beyond that. I believe, it crashes if you crank the speed way up then down. because it starts rounding off once you get to higher numbers you start getting decimal values. and when you turn it back down after that it lands on 0.13 not 0.12 then one more crank down crashes the program
Sorry I left review comment in wrong place earlier.
I reworked the fix to |
Added special case to not run slower than 0.12 real time or 80000 real microseconds per tick.
Need to first close the submodule and merge prior to this one: