Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#286] Updates to time driver to avoid crash when slowed #392

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

jlucas9
Copy link
Contributor

@jlucas9 jlucas9 commented Oct 17, 2024

Added special case to not run slower than 0.12 real time or 80000 real microseconds per tick.

Need to first close the submodule and merge prior to this one:

Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, stops at 0.12 as expected, and doesn't crash. Still was some weird behavior when I increased speed by too much, but allowed me to slow back down without crashing as well, so looks good to me!

Copy link
Contributor

@Isgaroth-the-Green Isgaroth-the-Green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also found it to work as intended.

Copy link

@dacarter22 dacarter22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found to work as intended unless rapidly sped up then slowed down in which case decimal values change the lower limit to .13 and then crashes if lowered beyond that. I believe, it crashes if you crank the speed way up then down. because it starts rounding off once you get to higher numbers you start getting decimal values. and when you turn it back down after that it lands on 0.13 not 0.12 then one more crank down crashes the program
Sorry I left review comment in wrong place earlier.

@msuder
Copy link
Contributor

msuder commented Oct 28, 2024

I reworked the fix to
#286
to fix the crash David Carter saw and to make speed-up/slow-down more robust in general.

@jlucas9 jlucas9 merged commit a2230a2 into dev Oct 29, 2024
4 checks passed
@jlucas9 jlucas9 deleted the nos3#286 branch October 29, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants