[nasa/nos3#380] fss checkout application #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple Checkout files to work for FSS
…ted generic_adcs includes paths in cmake to include the new shared directory for the fss device
kevincbruce
requested review from
jlucas9,
szemerick,
msuder,
Donnie-Ice,
rjbrown2,
dccutrig,
dacarter22,
zlynch2 and
Isgaroth-the-Green
|
Did you add the checkout app to make checkout? in order to launch standalone with make checkout? |
…d folders, added a sim_truth_interface to the configuration, and setup environment for quick testing of the FSS checkout for others to review;
|
Just pushed some changes to this. You'll still need to build the generic_fss standalone checkout manually, but the rest of the changes for testing are documented in the ./scripts/checkout.sh file and preconfigured for ease. |
jlucas9
approved these changes
Dec 18, 2024
I did not yet, since I didn't know about that step (wasn't present yet in other projects, just got added). Will look at John's changes and see if that fixed, if not will push a fix. Good catch! @zlynch2 |
rjbrown2
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checkout application for FSS to run standalone, reorganized FSS directories to match new standards, and updated ADCS to be able to read the directory with FSS's device files.
If I recall, basic test is to just see if it builds, but reviewing code to verify that I am not missing any methods and how I'm calling request data is correct would be appreciated.
Sub-PRs that must be merged first:
nasa-itc/generic_fss#7
nasa-itc/generic_adcs#6