[nasa/nos3#426] Resolve SBN Segfault when client not available #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlucas9
requested review from
msuder,
kevincbruce,
rjbrown2,
dccutrig,
dacarter22,
zlynch2 and
Isgaroth-the-Green
|
Tested, commented out lines 96-98 onair launch in fsw_cfs_launch.sh script. I would suggest making that comment permanent if we dont want to launch onair at this current merge. Onair isnt running, comfirmed commanding and telemetry with YAMCS. Approving. |
zlynch2
approved these changes
Dec 18, 2024
kevincbruce
approved these changes
Dec 20, 2024
dacarter22
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that SBN would segfault and then crash all of FSW should it not be able to create the connection to a client. The SBN code was updated to default to localhost should hostname resolution fail.
How to test:
./scripts/fsw/fsw_cfs_launch.shcomment out OnAIRmake clean && makemake launchThe following merge requests must be closes and submodules updated here prior to closure:
Closes #426