-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nasa/nos3#427] radio checkout #451
Conversation
…t testing. Having issues running GSW in make checkout for radio linking. Config changes should be reverted before merge
…ut.sh and cosmos_launch.sh to get radio sim connected successfully
Once above comments are fixed I will approve. I pulled and checkout works. I see all commands come down in the sim. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #451 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 1
Lines ? 3
Branches ? 0
=====================================
Hits ? 0
Misses ? 3
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Thanks Donnie! Will make the changes and update the instructions with the right mods after class. |
CI not working correctly yet, the successful run pushed them to a new branch for some reason. Trying to use github ENVs to push to the correct branch. |
Reviewed this pull request and ran the tests as specified and all seems fine. |
…mmented out radio specific parts of the checkout script; removed redundant cosmos_launch script
…os3#427-radio-checkout
Should have reverted minimal and nos3-mission to base values, and commented out stuff specific for this checkout in the checkout.sh. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked after changes, checkout builds and launches. also confirmed normal nos operations with adcs in mode 2. Approving.
Merged subrequests. Will merge top level either when I get back home from a thing I had, or when I make sure git works on my personal laptop if I'm snowed in at ESB a few hours. |
Added a checkout application for the generic_radio component. Have verified the checkout launches and can be commanded in the newest push. Currently, the branch is set up to run out of the box, so any global files will need to be commented out or modified as necessary to reset to the base configuration before it is merged.
Steps:
Enable Radio in NOS3 minimal, and uncomment radio part of checkout.sh in scripts.
make clean
make debug
cd components/generic_reaction_wheel/fsw/standalone/build
(
mkdir build
in the standalone directory if needed, thencd build
)make clean
(if build directory already exists)cmake .. -DTGTNAME=cpu1
make
exit
make clean
make
make checkout
The following submodule PRs must be merged and updated first:
nasa-itc/hwlib#11
nasa-itc/generic_radio#7
Closes #427