Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#427] radio checkout #451

Merged
merged 22 commits into from
Jan 14, 2025
Merged

[nasa/nos3#427] radio checkout #451

merged 22 commits into from
Jan 14, 2025

Conversation

kevincbruce
Copy link
Contributor

@kevincbruce kevincbruce commented Jan 13, 2025

Added a checkout application for the generic_radio component. Have verified the checkout launches and can be commanded in the newest push. Currently, the branch is set up to run out of the box, so any global files will need to be commented out or modified as necessary to reset to the base configuration before it is merged.

Steps:

Enable Radio in NOS3 minimal, and uncomment radio part of checkout.sh in scripts.

make clean
make debug
cd components/generic_reaction_wheel/fsw/standalone/build
(mkdir build in the standalone directory if needed, then cd build)
make clean (if build directory already exists)
cmake .. -DTGTNAME=cpu1
make
exit
make clean
make
make checkout

The following submodule PRs must be merged and updated first:
nasa-itc/hwlib#11
nasa-itc/generic_radio#7

Closes #427

scripts/cosmos_launch.sh Outdated Show resolved Hide resolved
cfg/nos3-mission.xml Outdated Show resolved Hide resolved
@zlynch2
Copy link

zlynch2 commented Jan 14, 2025

Once above comments are fixed I will approve. I pulled and checkout works. I see all commands come down in the sim.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@3c61261). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #451   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?       1           
  Lines          ?       3           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?       3           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevincbruce
Copy link
Contributor Author

Thanks Donnie! Will make the changes and update the instructions with the right mods after class.

@Donnie-Ice
Copy link
Contributor

CI not working correctly yet, the successful run pushed them to a new branch for some reason. Trying to use github ENVs to push to the correct branch.

@msuder
Copy link
Contributor

msuder commented Jan 14, 2025

Reviewed this pull request and ran the tests as specified and all seems fine.

@kevincbruce kevincbruce requested a review from zlynch2 January 14, 2025 18:19
@kevincbruce
Copy link
Contributor Author

Should have reverted minimal and nos3-mission to base values, and commented out stuff specific for this checkout in the checkout.sh.

Copy link

@zlynch2 zlynch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked after changes, checkout builds and launches. also confirmed normal nos operations with adcs in mode 2. Approving.

@kevincbruce
Copy link
Contributor Author

Merged subrequests. Will merge top level either when I get back home from a thing I had, or when I make sure git works on my personal laptop if I'm snowed in at ESB a few hours.

@kevincbruce kevincbruce merged commit daf759f into dev Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants