Combine all library files into a single lib.zig #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The biggest change is that the Uservalue functions in lua 54 no longer have Index in the name.
Now lua 5.1 and luajit work. The last thing is Luau
natecraddock
force-pushed
the
combine-libs
branch
from
3fb57d1 to
19c1a0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is an overall win.
+1,437 −7,755So there is some added complexity (some of the functions aren't as simple as they used to be), but the majority of the API is no longer duplicated.
This is nice because in most cases now, there is just one thing to update. I think this is worth the slightly less simple implementation.