Skip to content

Commit

Permalink
fix: resolution -> size
Browse files Browse the repository at this point in the history
Makie v0.20.0 deprecated the `resolution` argument, replacing it
with `size` [1].  This causes Makie to emit deprecation warnings when a theme
from TuePlots is loaded.

Change that argument in TuePlots too.

[1]: https://github.com/MakieOrg/Makie.jl/releases/tag/v0.20.0
  • Loading branch information
musoke committed May 6, 2024
1 parent 635b59d commit d319b26
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/to_makie.jl
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function MakieCore.Theme(
end

if fontsize
main, small = base_fontsize_to_sizes(setting.base_fontsize)
@show main, small = base_fontsize_to_sizes(setting.base_fontsize)
theme = merge(
MakieCore.Theme(
fontsize = main,
Expand Down Expand Up @@ -75,8 +75,8 @@ function MakieCore.Theme(
end
width *= width_coeff
height = width * subplot_height_to_width_ratio * nrows / ncols
resolution = (width * POINTS_PER_INCH, height * POINTS_PER_INCH)
theme = merge(MakieCore.Theme(resolution = resolution), theme)
size = (width * POINTS_PER_INCH, height * POINTS_PER_INCH)
theme = merge(MakieCore.Theme(size = size), theme)
end

if thinned
Expand Down

0 comments on commit d319b26

Please sign in to comment.