DR2-2118 Allow ReportBatchItemFailures on lambda event mappings.

These are possible for SQS and Dynamo. I've added in a variable for each even though we're not using the Dynamo one for now.
nationalarchives · Feb 20, 2025 · dca5b04 · dca5b04
1 parent 7839ff9
commit dca5b04
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/lambda/main.tf b/lambda/main.tf
@@ -105,6 +105,7 @@ resource "aws_lambda_event_source_mapping" "sqs_queue_mappings" {
   function_name                      = local.lambda_arn
   batch_size                         = var.sqs_queue_mapping_batch_size
   maximum_batching_window_in_seconds = var.sqs_queue_batching_window
+  function_response_types            = var.sqs_report_batch_item_failures == true ? ["ReportBatchItemFailures"] : null
   dynamic "scaling_config" {
     for_each = each.value == null ? [] : [each.value]
     content {
@@ -119,6 +120,7 @@ resource "aws_lambda_event_source_mapping" "sqs_queue_mappings_ignore_enabled" {
   function_name                      = local.lambda_arn
   batch_size                         = var.sqs_queue_mapping_batch_size
   maximum_batching_window_in_seconds = var.sqs_queue_batching_window
+  function_response_types            = var.sqs_report_batch_item_failures == true ? ["ReportBatchItemFailures"] : null
   dynamic "scaling_config" {
     for_each = each.value == null ? [] : [each.value]
     content {
@@ -131,10 +133,11 @@ resource "aws_lambda_event_source_mapping" "sqs_queue_mappings_ignore_enabled" {
 }
 
 resource "aws_lambda_event_source_mapping" "dynamo_stream_event_source_mapping" {
-  count             = var.dynamo_stream_config == null ? 0 : 1
-  event_source_arn  = var.dynamo_stream_config.stream_arn
-  function_name     = local.lambda_name
-  starting_position = var.dynamo_stream_config.starting_position
+  count                   = var.dynamo_stream_config == null ? 0 : 1
+  event_source_arn        = var.dynamo_stream_config.stream_arn
+  function_name           = local.lambda_name
+  starting_position       = var.dynamo_stream_config.starting_position
+  function_response_types = var.dynamo_report_batch_item_failures == true ? ["ReportBatchItemFailures"] : null
 }
 
 resource "aws_lambda_permission" "lambda_permissions" {

diff --git a/lambda/variables.tf b/lambda/variables.tf
@@ -120,6 +120,16 @@ variable "sqs_queue_batching_window" {
   default = 0
 }
 
+variable "sqs_report_batch_item_failures" {
+  description = "Only valid if an SQS event mapping is configured. Sets 'Report batch item failures' on the mapping."
+  default     = false
+}
+
+variable "dynamo_report_batch_item_failures" {
+  description = "Only valid if a Dynamo event mapping is configured. Sets 'Report batch item failures' on the mapping."
+  default     = false
+}
+
 variable "filename" {
   description = "Allows a filename to be passed directly to the module instead of using the generic ones"
   default     = ""