DR2-1668 Use RATE for DLQ alarms. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that if we get a message in a DLQ where there is already a message in the DLQ, we don't get another notification. Repeating messages for alarms that don't change state is a bit complicated so we'll go with this as a solution now. The period is 60 seconds so we shouldn't get massively spammed by a huge number of messages entering the DLQ at once.
techncl
reviewed
Jun 13, 2024
sqs/main.tf
Outdated
| QueueName = "${var.queue_name}-dlq" | ||
| } | ||
| metric_name = "ApproximateNumberOfMessagesVisible" | ||
| period = 60 |
There was a problem hiding this comment.
Just to add, should/could these periods be added to a variable?
There was a problem hiding this comment.
Yeah, can do. I've added a single variable as I can't see why we'd want different evaluation periods for the different metrics. I've defaulted them to 60 as this seems sensible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that if we get a message in a DLQ where there is already a
message in the DLQ, we don't get another notification.
Repeating messages for alarms that don't change state is a bit
complicated so we'll go with this as a solution now.
The period is 60 seconds so we shouldn't get massively spammed by a huge
number of messages entering the DLQ at once.