Generalise log bucket policy for other log sources #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyhashemi
commented
Oct 1, 2024
s3_logs/main.tf
Outdated
| @@ -1,8 +1,32 @@ | |||
|
|
|||
| data "aws_iam_policy_document" "policy_document" { | |||
There was a problem hiding this comment.
now this is defined at the s3_logs module level, when using this directly insteas of via the s3 module, users get the extra restrictions outlined in default_log_bucket_policy.json.tpl by default.
See https://github.com/nationalarchives/da-ayr-terraform/pull/237 for example
anthonyhashemi
force-pushed
the
generalise-log-bucket-policy-for-other-sources
branch
from
8ed4d1b to
f36e8cc
Compare
anthonyhashemi
commented
Oct 1, 2024
| @@ -13,7 +13,7 @@ | |||
| "Resource": "arn:aws:s3:::${log_bucket_name}/*", | |||
| "Condition": { | |||
| "ArnLike": { | |||
| "aws:SourceArn": "arn:aws:s3:::${bucket_name}" | |||
| "aws:SourceArn": "${source_arn}" | |||
There was a problem hiding this comment.
pass in source_arn as opposed to making it specific to s3 bucket sources only
anthonyhashemi
force-pushed
the
generalise-log-bucket-policy-for-other-sources
branch
4 times, most recently
from
12f3009 to
0caf17f
Compare
…nd s3 logging modules and output the policy document to attach it outside to deal with scenarios of circular dependency
anthonyhashemi
force-pushed
the
generalise-log-bucket-policy-for-other-sources
branch
from
0caf17f to
ecb097a
Compare
|
CLosing in favour of #69 as no longer needed generalising log bucket policy for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalise log bucket policy for other log sources such as cloudfront distributions (see https://github.com/nationalarchives/da-ayr-terraform/pull/237)