Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InternalIP fallback if no external is found #322

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add InternalIP fallback if no external is found #322

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4fbc4f6
Add InternalIP fallback if no external is found
Jun 9, 2021
f132da3
whitespace fix
Jun 10, 2021
5a702ba
whitespace replace space with tabs
ZleFox Jun 10, 2021
ab7787c
Merge branch 'bootconfig_fix' of github.com:ZleFox/nats-operator into…
Aug 5, 2021
bf234e1
move labels to take precedence over internal ip
Aug 5, 2021
1fdfa34
Merge branch 'nats-io:master' into bootconfig_fix
ZleFox Aug 17, 2021
a8aaa91
Merge branch 'nats-io:master' into bootconfig_fix
ZleFox Nov 19, 2021
96ef9f0
Merge branch 'nats-io:master' into bootconfig_fix
ZleFox Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pkg/bootconfig/boot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,18 @@ func (c *Controller) Run(ctx context.Context) error {
break
}
}
ZleFox marked this conversation as resolved.
Show resolved Hide resolved

// Fallback to use a label to find the external address.
if !ok {
externalAddress, ok = node.Labels[c.opts.TargetTag]
if !ok || len(externalAddress) == 0 {
for _, addr := range node.Status.Addresses {
// Fallback to use the InternalIP if no label is defined
if addr.Type == "InternalIP" {
externalAddress = addr.Address
ok = true
}
}
}
if !ok || len(externalAddress) == 0 {
return errors.New("Could not find external IP address.")
}
Expand Down