-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add direct printing #2743
Add direct printing #2743
Conversation
After going back and forth and re-writing this from scratch, I eventually realized that the PrintNavItem (previous PrintLink) was actually already written as a Function Component. |
Possibly fatal issue: When Partial Page Rendering is active, the content of the unrendered pages literally does not exist and thus cannot be passed to the printer. |
As pointed out in gitter a possible solution to the Partial Page Rendering(PPR) problem would be to create a temporary iframe that just loads the existing /page to then render the whole document for printing. It could possible even be hidden visually from the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I see the problem this is trying to solve. Can you elaborate?
/print
is being used for other links. For instance it's what Google is using to track several of our reported issues on Chrome.
this is the result, zoomed to see the icon in the top left of the page. all pages are printed, but those not loaded have the loading icon. 55 pages document, only 4 printed correctly. |
I think I'll close this issue for now. I'm not sure the issue this is trying to solve actually needs to be solved. Further discussion can happen on that open issue. |
This PR resolves #2742.
The removal of the PrintPage and
/print
route have been left for a future PR, if their removal is deemed necessary.Implementation Tasks:
navbar/print.navitem.jsx
to call the print function directly instead of linking to/print
@media print
CSS to BrewRenderer styling