Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix deleted recents issue #3989

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dbolack-ab
Copy link
Collaborator

@dbolack-ab dbolack-ab commented Jan 15, 2025

Description

This attempts to prevent the deleted "Recently Viewed" listings by not adding them to the list if the relevant ID is falsey.

Related Issues or Discussions

Reviewer Checklist

Replace the list below with specific features you want reviewers to look at.

*Reviewers, refer to this list when testing features, or suggest new items *

  • Verify new features are functional
    • Create a new brew, save it, then delete it. Verify it does not show up on a reloaded Recents list
  • Verify old features have not broken
    • Make certain Recents are still properly populated.
  • Test for edge cases / try to break things

@dbolack-ab dbolack-ab self-assigned this Jan 15, 2025
@dbolack-ab dbolack-ab added tweak Small, non-breaking change 🔍 R0 - Needs first review 👀 PR ready but has not been reviewed labels Jan 15, 2025
@5e-Cleric
Copy link
Member

tested by doing:

  1. created brew, saved it
  2. confirm the brew appears in edit recent list
  3. deleted the brew
  4. brew is still appearing in the recently edited brews

@5e-Cleric 5e-Cleric added 🔍 R3 - Reviewed - Awaiting Fixes 🔧 PR is okayed but needs fixes before merging and removed 🔍 R0 - Needs first review 👀 PR ready but has not been reviewed labels Feb 25, 2025
@dbolack-ab
Copy link
Collaborator Author

Looking at this I am very confused. I don't know what I thought it did or why it would solve that. I can only assume I dropped a big commit.

@dbolack-ab dbolack-ab marked this pull request as draft February 28, 2025 05:36
@calculuschild calculuschild added 🔍 R_ - Not ready for review 🕑 and removed 🔍 R3 - Reviewed - Awaiting Fixes 🔧 PR is okayed but needs fixes before merging labels Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

Add function to update recent brews
4 participants