Migrate the justified paragraphs extension to an NPM #4044
Conversation
|
I would like to see the NPM package for this before merging. |
dbolack-ab
added
the
🔍 R0 - Needs first review 👀
shared/naturalcrit/markdown.js
Outdated
| @@ -7,6 +7,7 @@ import MarkedExtendedTables from 'marked-extended-tables'; | |||
| import { markedSmartypantsLite as MarkedSmartypantsLite } from 'marked-smartypants-lite'; | |||
| import { gfmHeadingId as MarkedGFMHeadingId, resetHeadings as MarkedGFMResetHeadingIDs } from 'marked-gfm-heading-id'; | |||
| import { markedEmoji as MarkedEmojis } from 'marked-emoji'; | |||
| import MarkedJustifiedParagraphs from 'marked-justified-paragraphs'; | |||
There was a problem hiding this comment.
We might rename this extension to "aligned paragraphs" or something. We support left align, right align, and center align. Justified is the one alignment type that isn't supported.
There was a problem hiding this comment.
When I worked in print, these were "Right Justified, Left Justified, Center Justified, or Fully ( which we don't use here ) Justified"
It is the proper term. HTML properties name it weird.
There was a problem hiding this comment.
I can't find a single reference online calling it "right justified, left justified", but we can keep it for now; it's not critical.
When we transfer this over to the naturalcrit org we can re-evaluate. Ideally it would share the same naming conventions as the rest of the Markdown spec just for consistency.
|
Just one issue in the package, on the readme: |
calculuschild
added
🔍 R3 - Reviewed - Awaiting Fixes 🔧
Description
Relocates the paragraph justification markers to their own module.
https://github.com/dbolack-ab/marked-justified-paragraphs
Related Issues or Discussions
Relates to #4035
QA Instructions, Screenshots, Recordings
Reviewer Checklist
Replace the list below with specific features you want reviewers to look at.
*Reviewers, refer to this list when testing features, or suggest new items *
:-:-:-: