Release v2.3.0 #133
Merged
Release v2.3.0 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base DataSource/DataTarget classes already have this flag set by default.
…aTarget inherit from Job directly.
…rm toggles to work.
Fix SSoT Jobs
fix jobs import
Remove version from Docker Compose
MySQL 8 now complains that the default-authentication-plugin=mysql_native_password is not found and the container then exits. I removed this setting from my environment and the container comes up and all unit tests pass.
Update contributing.md
…-annotations-plugin Replace mkdocs-version-annotations with markdown-version-annotations
Fix comments in flake8 file
Fully integrate ruff for formatting and linting
Removes duplicate tasks.py, but leaves the one that is in the same location as the other cookiecutter templates.
gsnider2195
commented
Aug 5, 2024
pyproject.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "cookiecutter-nautobot-app" | |||
| version = "1.0.0" | |||
| version = "2.3.0" | |||
There was a problem hiding this comment.
Was there a reason the version number wasn't being bumped in the pyproject.toml?
There was a problem hiding this comment.
Let's change the mode: https://python-poetry.org/docs/basic-usage/#operating-modes
…tobot-app into release/v2.3.0
gsnider2195
commented
Aug 6, 2024
| @@ -17,48 +17,25 @@ pyyaml = "*" | |||
|
|
|||
| [tool.poetry.group.dev.dependencies] | |||
| bandit = "*" | |||
| black = "*" | |||
| coverage = "^7.3.2" | |||
| coverage = "*" | |||
There was a problem hiding this comment.
I think we need to pin coverage for the same reason we pinned it in core:
https://github.com/nautobot/nautobot/blob/8dbbdaa307c90a5e315257c1d4f866c5b0f263af/pyproject.toml#L217
Newer versions cause problems with pdb breakpoints
There was a problem hiding this comment.
Will follow up later #136
cmsirbu
approved these changes
Aug 7, 2024
Co-authored-by: Cristian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.