Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Change Log Fragments #60

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Implement Change Log Fragments #60

merged 5 commits into from
Jan 5, 2024

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Jan 4, 2024

Closes NaN

What's Changed

  • Added towncrier changelog fragments support.

filename = "docs/admin/release_notes/version_X.Y.md"
template = "development/towncrier_template.j2"
start_string = "<!-- towncrier release notes start -->"
issue_format = "[#{issue}](https://github.com/nautobot/nautobot/issues/{issue})"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be variablized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better, this is taken from Nautobot core repo.

@whitej6 Should I create followup ticket for it or try to fix it in this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but should it be <repo>/issues/{issue}?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I was on the line 135 not 138, will fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@whitej6 whitej6 merged commit 8df66ae into develop Jan 5, 2024
1 check passed
@whitej6 whitej6 deleted the u/snaselj-towncrier branch January 5, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants