-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Change Log Fragments #60
Conversation
filename = "docs/admin/release_notes/version_X.Y.md" | ||
template = "development/towncrier_template.j2" | ||
start_string = "<!-- towncrier release notes start -->" | ||
issue_format = "[#{issue}](https://github.com/nautobot/nautobot/issues/{issue})" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be variablized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better, this is taken from Nautobot core repo.
@whitej6 Should I create followup ticket for it or try to fix it in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but should it be <repo>/issues/{issue}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I was on the line 135 not 138, will fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Closes NaN
What's Changed