Fix ruff #89
Closed
Fix ruff #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| def ruff(context, action="lint", fix=False, output_format="text"): | ||
| def ruff(context, action=["lint"], fix=False, output_format="full"): |
There was a problem hiding this comment.
Is this ok? I don't remember when mutable can't be used, I know there should not be an empty list, but would this be preferred?
def ruff(context, action=None, fix=False, output_format="full"):
if action is None:
action = ["lint"]There was a problem hiding this comment.
Good point.
In the end, seems to me better to split it to two separate tasks, as it has different args anyway.
The proposal is here, could you check it pls.?
nautobot/nautobot-app-dev-example#5
Overall, I would rather process approvals in nautobot-app-dev-example as there it's much easier to test changes. After the approval there, pull request to this repository cookiecutter-nautobot-app will be backported.
|
Closing as duplicate #91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: NaN
What's Changed