Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff integration 2 #16

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Ruff integration 2 #16

merged 3 commits into from
Apr 19, 2024

Conversation

Kircheneer
Copy link
Contributor

@Kircheneer Kircheneer commented Apr 15, 2024

  • fixes test_basic package_name variable usage
  • re-enable ruff against migration files

Note that I have not changed the invoke setup as there wasn't a clear consensus on doing that. If you want a one-stop-shop for formatting, use inv a[utoformat].

Copy link
Contributor

@snaselj snaselj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

glennmatthews
glennmatthews previously approved these changes Apr 16, 2024
Copy link
Contributor

@cmsirbu cmsirbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional fixes and getting CI back working again. Merging!

@cmsirbu cmsirbu merged commit 7ec58ea into develop Apr 19, 2024
15 checks passed
@cmsirbu cmsirbu deleted the ruff-integration-2 branch April 19, 2024 11:10
@cmsirbu cmsirbu mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants