Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pylint_django migrations check #50

Merged
merged 3 commits into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/50.added
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added pylint django migrations checker to the `invoke pylint` command.
19 changes: 17 additions & 2 deletions tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -709,8 +709,23 @@ def hadolint(context):
@task
def pylint(context):
"""Run pylint code analysis."""
command = 'pylint --init-hook "import nautobot; nautobot.setup()" --rcfile pyproject.toml nautobot_dev_example'
run_command(context, command)
exit_code = 0

base_pylint_command = 'pylint --verbose --init-hook "import nautobot; nautobot.setup()" --rcfile pyproject.toml'
command = f"{base_pylint_command} nautobot_dev_example"
if not run_command(context, command, warn=True):
exit_code = 1

# run the pylint_django migrations checkers on the migrations directory
migrations_pylint_command = (
f"{base_pylint_command} --load-plugins=pylint_django.checkers.migrations"
" --disable=all --enable=new-db-field-with-default,missing-backwards-migration-callable"
" nautobot_dev_example.migrations"
)
if not run_command(context, migrations_pylint_command, warn=True):
exit_code = 1

raise Exit(code=exit_code)


@task(aliases=("a",))
Expand Down