WIP - Add Software Notice Model and Views #408
+1,140
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanukes
force-pushed
the
next3.0-sw-notice
branch
from
18fb8db to
ccec30f
Compare
romanukes
force-pushed
the
next3.0-sw-notice
branch
from
ccec30f to
75f89c6
Compare
romanukes
force-pushed
the
next3.0-sw-notice
branch
from
6083d64 to
4eadb61
Compare
Comment on lines
+53
to
+68
| NavMenuButton( | ||
| link="plugins:nautobot_device_lifecycle_mgmt:softwarenotice_add", | ||
| title="Add", | ||
| icon_class="mdi mdi-plus-thick", | ||
| button_class=ButtonColorChoices.GREEN, | ||
| permissions=[ | ||
| "nautobot_device_lifecycle_mgmt.add_softwarenotice", | ||
| ], | ||
| ), | ||
| NavMenuButton( | ||
| link="plugins:nautobot_device_lifecycle_mgmt:softwarenotice_import", | ||
| title="Import", | ||
| icon_class="mdi mdi-database-import-outline", | ||
| button_class=ButtonColorChoices.BLUE, | ||
| permissions=["nautobot_device_lifecycle_mgmt.add_softwarenotice"], | ||
| ), |
There was a problem hiding this comment.
- Use
NavMenuAddButtoninstead of a genericNavMenuButtonfor the "Add" button. - In current core versions we don't have an
Importbutton in most nav menu entries any more.
| """Table for SoftwareNotice list view.""" | ||
|
|
||
| pk = ToggleColumn() | ||
| id = tables.LinkColumn( |
There was a problem hiding this comment.
LinkColumn is deprecated in django-tables2, use a regular Column with linkify=True instead.
| @@ -0,0 +1,68 @@ | |||
| {% extends 'generic/object_detail.html' %} | |||
There was a problem hiding this comment.
Can this version target Nautobot 2.4 as a minimum and use the UI Component Framework for this view instead of the below HTML?
|
|
||
| <tr> | ||
| <td>Release Date</td> | ||
| <td>{% if object.software_version.release_date %} {{ object.software_version.release_date }} {% else %} — {% endif %}</td> |
There was a problem hiding this comment.
If unable to use the component framework, please at least make use of standard helper template tags like {{ object.software_version.release_date|placeholder }} and {{ object.device_type|hyperlinked_object }}
Comment on lines
+187
to
+200
| software_version_id = django_filters.ModelMultipleChoiceFilter( | ||
| field_name="software_version", | ||
| queryset=SoftwareVersion.objects.all(), | ||
| label="Software Version", | ||
| ) | ||
| software_version = django_filters.ModelMultipleChoiceFilter( | ||
| field_name="software_version", queryset=SoftwareVersion.objects.all(), label="Software Version" | ||
| ) | ||
| software_version_version = django_filters.ModelMultipleChoiceFilter( | ||
| field_name="software_version__version", | ||
| queryset=SoftwareVersion.objects.all(), | ||
| to_field_name="version", | ||
| label="Software Version (String)", | ||
| ) |
There was a problem hiding this comment.
Can/should these three be consolidated into a single filter using NaturalKeyOrPKMultipleChoiceFilter? Same comment on others below.
Comment on lines
+222
to
+224
| end_of_support__gte = django_filters.DateFilter(field_name="end_of_support", lookup_expr="gte") | ||
| end_of_support__lte = django_filters.DateFilter(field_name="end_of_support", lookup_expr="lte") | ||
| end_of_support__isnull = django_filters.BooleanFilter(field_name="end_of_support", lookup_expr="isnull") |
There was a problem hiding this comment.
Are these extensions not automatically added to a DateFilter by core?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding “Software Notices” model. Like the Hardware Notices, this model will store additional dates for the Software Versions (End of Sale, End of SW Releases, End of Security Patches, End of Support). Optionally, a notice could store different dates per Device Type.