Integrate the job from #387 and update it to use the new migrated_to_core_model fields from #400
#411
+1,229
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsnider2195
commented
Jan 24, 2025
Comment on lines
108
to
111
| try: | ||
| with transaction.atomic(): | ||
| try: | ||
| self.migrate_dlm_models_to_core() | ||
| finally: | ||
| if dryrun: | ||
| raise RollbackTransaction("Dryrun mode. Rolling back changes.") | ||
| except RollbackTransaction: | ||
| self.logger.info("Transaction rolled back.") |
There was a problem hiding this comment.
I changed this slightly in a later commit
…lation to DLMToNautoboCoreModelMigration job
…tead of `software_tmp` fields. escape log messages. small optimization
…ed_to_core_model` foreign key.
gsnider2195
force-pushed
the
u/gas-402-dlm-to-core-migrations
branch
from
caa4e31 to
dea7947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #402
What's Changed
This is based off of my branch for #400. The merge conflicts are already resolved in my branch and I didn't want to have to do that again to try to base this off of #387. I added the job from #387 in commit d99a7bb and each subsequent commit was built incrementally to make this easier to review. I'll rebase this after #400 is merged.
Screenshots
TODO
dlm_to_core_id_map