-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove conditional views in Golden Config #847
Open
jtdub
wants to merge
30
commits into
develop
Choose a base branch
from
gc-app-settings
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtdub
requested review from
itdependsnetworks,
jeffkala and
nkallergis
as code owners
December 11, 2024 18:44
jtdub
force-pushed
the
gc-app-settings
branch
2 times, most recently
from
December 13, 2024 15:32
47e4b89
to
3113bf9
Compare
jtdub
changed the title
WIP | Remove conditional views in Golden Config
Remove conditional views in Golden Config
Dec 16, 2024
|
AS far as this concern: "UI-based configuration settings would apply to each device individually within a dynamic group, rather than checking the configuration globally once." I don't expect this to cause much performance issue as we already have function |
jtdub
force-pushed
the
gc-app-settings
branch
from
December 19, 2024 19:22
1691aa5
to
452947c
Compare
jeffkala
reviewed
Dec 19, 2024
nautobot_golden_config/migrations/0031_goldenconfigsetting_backup_enabled_and_more.py
Outdated
Show resolved
Hide resolved
jeffkala
reviewed
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #842.
Navigation views display all options regardless of what is enabled or disabled:
Golden Config Settings displays whether backups and intended are enabled:
Creating and Updating Golden Config Settings in the UI:
Reading the Golden Config Settings in the UI.