Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add single network view and IP Address type support #303

Merged
merged 10 commits into from
Dec 20, 2023
Merged

Add single network view and IP Address type support #303

merged 10 commits into from
Dec 20, 2023

Conversation

Dav-C
Copy link
Contributor

@Dav-C Dav-C commented Dec 12, 2023

  • Add a new setting to optionally specify a single Network View to load from Infoblox
  • Address the possibility of an extensible attribute containing multiple values
  • Add support for Nautobot IP address types
  • Move debug message Creating IP Address {addr} under a debug check to prevent unintended logging

@Dav-C Dav-C requested review from qduk, jdrew82 and a team as code owners December 12, 2023 18:57
jdrew82
jdrew82 requested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things to address.

nautobot_ssot/integrations/infoblox/diffsync/models/nautobot.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
jdrew82
jdrew82 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

qduk
qduk approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@qduk qduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Dav-C!

@jdrew82 jdrew82 merged commit 00dc985 into nautobot:develop Dec 20, 2023
15 checks passed
@jdrew82 jdrew82 mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qduk qduk qduk approved these changes

@jdrew82 jdrew82 jdrew82 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dav-C @jdrew82 @qduk