Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Librenms manufacturers fix #657

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Librenms manufacturers fix #657

merged 6 commits into from
Jan 14, 2025

Conversation

bile0026
Copy link
Contributor

Closes: #656

What's Changed

Fixed some missing Manufacturers in the os_manufacturer_mapping constants.

To Do

  • [ X] Explanation of Change(s)
  • [ X ] Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@bile0026 bile0026 requested a review from a team as a code owner January 14, 2025 21:19
@bile0026 bile0026 requested a review from jdrew82 January 14, 2025 21:20
@bile0026 bile0026 self-assigned this Jan 14, 2025
@bile0026 bile0026 added type: bug Issues/PRs addressing a bug. integration: librenms Issues/PRs for LibreNMS Integration labels Jan 14, 2025
jdrew82
jdrew82 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82 jdrew82 merged commit 5d110b9 into develop Jan 14, 2025
11 of 15 checks passed
@jdrew82 jdrew82 deleted the librenms_manufacturers_fix branch January 14, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrew82 jdrew82 jdrew82 approved these changes

Assignees

@bile0026 bile0026

Labels
integration: librenms Issues/PRs for LibreNMS Integration type: bug Issues/PRs addressing a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LibreNMS Integration missing some manufacturers in os_manufacturer_mapping
2 participants
@bile0026 @jdrew82