Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve ACI Tag color and device types settings #660

Merged
merged 9 commits into from
Jan 16, 2025
Merged

Preserve ACI Tag color and device types settings #660

merged 9 commits into from
Jan 16, 2025

Conversation

kingfetty
Copy link
Contributor

@kingfetty kingfetty commented Jan 15, 2025 •
edited
Loading

Closes: #654

What's Changed

Avoid duplicate key exception on startup by only passing tag name during tag enforcement.
Ensure tag content_types and color are properly configured.

To Do

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)

@kingfetty kingfetty requested review from chadell and a team as code owners January 15, 2025 19:50
@jdrew82
Copy link
Contributor

jdrew82 commented Jan 15, 2025

@kingfetty please address the ruff-lint error.

@jdrew82 jdrew82 added type: bug Issues/PRs addressing a bug. integration: ciscoaci Issues/PRs for Cisco ACI integration. labels Jan 15, 2025
jdrew82
jdrew82 requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change.

nautobot_ssot/integrations/aci/signals.py Outdated Show resolved Hide resolved
@kingfetty kingfetty requested a review from jdrew82 January 15, 2025 22:12
@kingfetty kingfetty changed the title Fix Bug 654 Preserve ACI Tag color and device types settings Jan 16, 2025
jdrew82
jdrew82 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82 jdrew82 merged commit 38544ab into nautobot:develop Jan 16, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrew82 jdrew82 jdrew82 approved these changes

@chadell chadell Awaiting requested review from chadell chadell is a code owner

Assignees

@kingfetty kingfetty

Labels
integration: ciscoaci Issues/PRs for Cisco ACI integration. type: bug Issues/PRs addressing a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ACI tag creation leaves content_types empty
2 participants
@kingfetty @jdrew82