Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vSphere Integration #701

Closed
wants to merge 14 commits into from
Closed

vSphere Integration #701

wants to merge 14 commits into from

Conversation

qduk
Copy link
Contributor

@qduk qduk commented Feb 18, 2025

Closes: #500

What's Changed

Adds the ability to sync directly with a vCenter instance. Currently, this is implemented as a one-way sync from vCenter into Nautobot. The following models are synced from vCenter:

  • DataCenter -> ClusterGroup
  • Cluster -> Cluster
  • Virtual Machine -> Virtual Machine
  • VM Interface -> VM Interface
  • IP Addresses -> IP Addresses
  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Add screenshots from Job Results to Documentation
  • Test against live vSphere with various setting configurations
  • Add @h4ndzdatm0ld as co-contributor

I am working on testing against a live instance of vCenter this week so I can get screenshots of job results, etc. However, I wanted to get this PR open so I can get some eyes on it.

@qduk qduk self-assigned this Feb 18, 2025
@qduk qduk requested a review from a team as a code owner February 18, 2025 18:38
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things to discuss/address.


urlpatterns = [
path(
"config/vsphere/<uuid:pk>/changelog/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you appear to be adding your own changelog view when we have SSoT logs and ObjectChange logs that should basically be covering this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was doing because that's what I saw here. However, you are totally right. I just included the needed mixins in the ViewSet and voila. It all worked. Should I change the Infoblox one?

@qduk qduk marked this pull request as draft February 19, 2025 18:25
@qduk qduk closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new VMWare Integration from existing VSphere plugin
2 participants