-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vSphere Integration #701
vSphere Integration #701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things to discuss/address.
nautobot_ssot/integrations/vsphere/diffsync/adapters/adapter_nautobot.py
Outdated
Show resolved
Hide resolved
|
||
urlpatterns = [ | ||
path( | ||
"config/vsphere/<uuid:pk>/changelog/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you appear to be adding your own changelog view when we have SSoT logs and ObjectChange logs that should basically be covering this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was doing because that's what I saw here. However, you are totally right. I just included the needed mixins in the ViewSet and voila. It all worked. Should I change the Infoblox one?
Closes: #500
What's Changed
Adds the ability to sync directly with a vCenter instance. Currently, this is implemented as a one-way sync from vCenter into Nautobot. The following models are synced from vCenter:
I am working on testing against a live instance of vCenter this week so I can get screenshots of job results, etc. However, I wanted to get this PR open so I can get some eyes on it.