Migrate Templates #199
Open
Migrate Templates #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,6 +57,6 @@ | |||
| {% include 'nautobot_version_control/diffs.html' with results=results %} | |||
|
|
|||
| {% if obj and settings.DOCS_ROOT %} | |||
| {% include 'inc/modal.html' with name='docs' content=obj|get_docs %} | |||
|
|
|||
There was a problem hiding this comment.
It was bonking out on get_docs, not sure what that does tbh
| @@ -306,6 +306,8 @@ def get(self, request, *args, **kwargs): # pylint: disable=W0613,C0116 # noqa: | |||
| { | |||
| "object": instance, | |||
| "results": diff, | |||
| # TODO: This should not be needed but did not render Tab in detail view without | |||
There was a problem hiding this comment.
As mentioned.
| @@ -4,6 +4,7 @@ | |||
| {% load helpers %} | |||
| {% load static %} | |||
| {% load tz %} | |||
| <!-- This view comes from clicking on the "Diff Type" icon, e.g. changed/added in a diff view --> | |||
There was a problem hiding this comment.
I could not update this to the standard templates, the view is rather different so I am not sure if this is expected or not.
| @@ -42,6 +42,5 @@ | |||
| </div> | |||
| </form> | |||
| {% if obj and settings.DOCS_ROOT %} | |||
| {% include 'inc/modal.html' with name='docs' content=obj|get_docs %} | |||
There was a problem hiding this comment.
It was bonking out on get_docs, not sure what that does tbh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.