-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue #352]: React suspense example #355
Open
rylew1
wants to merge
1
commit into
main
Choose a base branch
from
rylew/352-suspense-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+98
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import React from "react"; | ||
|
||
const InstantLoadGreeting = () => { | ||
return <h3>This should load instantly!</h3>; | ||
}; | ||
|
||
export default InstantLoadGreeting; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import { getTodos } from "./Todos2SecLoad"; | ||
|
||
interface Todo { | ||
userId: number; | ||
id: number; | ||
title: string; | ||
completed: boolean; | ||
} | ||
|
||
export default async function Todos1SecLoad() { | ||
const todos: Todo[] = await getTodos(1000); | ||
|
||
return ( | ||
<div> | ||
<h2>Todos</h2> | ||
<ul> | ||
{todos.slice(0, 10).map((todo) => ( | ||
<li key={todo.id}>{todo.title}</li> | ||
))} | ||
</ul> | ||
</div> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
interface Todo { | ||
userId: number; | ||
id: number; | ||
title: string; | ||
completed: boolean; | ||
} | ||
|
||
export async function getTodos(delay: number) { | ||
await new Promise((resolve) => setTimeout(resolve, delay)); | ||
const response = await fetch("https://jsonplaceholder.typicode.com/todos"); | ||
const data = (await response.json()) as Todo[]; | ||
return data; | ||
} | ||
export default async function Todos2SecLoad() { | ||
const todos: Todo[] = await getTodos(2000); | ||
|
||
return ( | ||
<div> | ||
<h2>Todos</h2> | ||
<ul> | ||
{todos.slice(0, 10).map((todo) => ( | ||
<li key={todo.id}>{todo.title}</li> | ||
))} | ||
</ul> | ||
</div> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import React from "react"; | ||
|
||
const Loader = ({ message }: { message: string }) => <h4>{message}</h4>; | ||
|
||
export default Loader; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import { useTranslations } from "next-intl"; | ||
import React, { Suspense } from "react"; | ||
|
||
import InstantLoadGreeting from "./InstantLoadGreeting"; | ||
import Loader from "./loader"; | ||
import Todos1SecLoad from "./Todos1SecLoad"; | ||
import Todos2SecLoad from "./Todos2SecLoad"; | ||
|
||
export default function Page() { | ||
const t = useTranslations("suspense"); | ||
return ( | ||
<> | ||
<h1>{t("title")}</h1> | ||
<InstantLoadGreeting /> | ||
<div className="grid-row grid-gap"> | ||
<div className="tablet:grid-col-6"> | ||
<Suspense | ||
fallback={<Loader message="This should take 1 second to load" />} | ||
> | ||
<Todos1SecLoad /> | ||
</Suspense> | ||
</div> | ||
<div className="tablet:grid-col-6"> | ||
<Suspense | ||
fallback={<Loader message="This should take 2 seconds to load" />} | ||
> | ||
<Todos2SecLoad /> | ||
</Suspense> | ||
</div> | ||
</div> | ||
</> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could use translation strings - just haven't done that yet