Pull in latest updated to USWDS Form Builder from base #62
Conversation
| # Actual USWDS mask functionality broken until this is fixed: | ||
| # https://github.com/uswds/uswds/issues/5517 | ||
| # append_to_option(options, :class, " usa-masked") |
There was a problem hiding this comment.
This upstream issue has been marked as resolved since v3.8.1, have we tested it?
The lock file looks be using USWDS 3.8.0 at the moment, so a minor bump to resolve this would be okay IMO, we don't need to do a big update to 3.11.0 as a part of this work.
Also the content us_form_with.tax_id_format needs added, like for the date picker below.
Though big picture, not sure about including a "tax_id_field" as a part of the generic Rails app. 🤔 @lorenyu any thoughts?
There was a problem hiding this comment.
I don't have strong preferences either way at this point since I think it's relatively easy to clean up one way or another later on, so I'm biased towards doing whatever is simplest for now. Longer term I could see this being part of flex.
| def date_picker(attribute, options = {}) | ||
| raw_value = object.send(attribute) if object | ||
|
|
||
| append_to_option(options, :hint, @template.content_tag(:p, I18n.t("us_form_with.date_picker_format"))) |
There was a problem hiding this comment.
The content us_form_with.date_picker_format needs added, here
Ticket
Changes
Context for reviewers
Testing