Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(plugin): boost test coverage #3333

Merged
merged 1 commit into from
Aug 10, 2023
Merged

test(plugin): boost test coverage #3333

merged 1 commit into from
Aug 10, 2023

Conversation

netil
Copy link
Member

@netil netil commented Aug 10, 2023 •
edited
Loading

Issue

#3332

Details

  • Exclude d3 modules to be transpiled for test build (some d3 code block scope, transpile wrongly and throws error)
  • Add test codes for plugins
  • Include again textoverlap plugin test(fixed and happened due to the transpile issue)

Result

Plugin test coverage increased:

  • From: 83.72% -> To: 94.25%
image

test(plugin): boost test coverage
fcb4053 
- Exclude d3 modules to be transpiled for test build
  (some d3 code block scope, transpile wrongly and throws error)
- Add test codes for plugins
- Include again textoverlap plugin test(fixed and happened due to the transpile issue)
@netil netil added the test label Aug 10, 2023
@netil netil self-assigned this Aug 10, 2023
@coveralls
Copy link

Coverage Status

coverage: 91.465% (+0.6%) from 90.859% when pulling fcb4053 on netil:test#3332 into b7ba810 on naver:master.

@netil netil merged commit 32d6d01 into naver:master Aug 10, 2023
5 checks passed
@netil netil deleted the test#3332 branch August 10, 2023 10:13
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 21, 2023
test(api): Increase test coverage for APIs
9093d4c 
Enforce test coverage under 90%

Ref naver#3333
@netil netil mentioned this pull request Aug 21, 2023
Merged
netil added a commit that referenced this pull request Aug 21, 2023
@netil
test(api): Increase test coverage for APIs (#3350)
ef4776a 
Enforce test coverage under 90%

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 22, 2023
test(api): Increase test coverage for APIs
bb05144 
Enforce test coverage under 90%

Ref naver#3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 22, 2023
test(interaction): Increase test coverage for interactions
41f4d47 
- Reinforce test coverage for interaction related codes
- Remove unused ‘else’ condition block from .generateTicks()
- Remove unused ‘jsonTreemp’ module

Ref naver#3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 22, 2023
test(interaction): Increase test coverage for interactions
041df79 
- Reinforce test coverage for interaction related codes
- Remove unused ‘else’ condition block from .generateTicks()
- Remove unused ‘jsonTreemp’ module

Ref naver#3333
@netil netil mentioned this pull request Aug 22, 2023
Merged
netil added a commit that referenced this pull request Aug 22, 2023
@netil
test(interaction): Increase test coverage for interactions (#3360)
6333297 
- Reinforce test coverage for interaction related codes
- Remove unused ‘else’ condition block from .generateTicks()
- Remove unused ‘jsonTreemp’ module

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 25, 2023
test(internals): Add tests for internals code
eff9dd1 
Reinforce test codees to increase coverage

Ref naver#3333
@netil netil mentioned this pull request Aug 25, 2023
Merged
netil added a commit that referenced this pull request Aug 25, 2023
@netil
test(internals): Add tests for internals code (#3373)
2de3d19 
Reinforce test codes to increase coverage

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 25, 2023
test(shape): Reinforce test coverage
b4834e6 
Add test cases for shapes to increase test coverage

Ref naver#3333
@netil netil mentioned this pull request Aug 25, 2023
Merged
netil added a commit that referenced this pull request Aug 25, 2023
@netil
test(shape): Reinforce test coverage (#3374)
cd9adc4 
Add test cases for shapes to increase test coverage

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 28, 2023
test(shapes): Add tests for shapes
5df17d9 
Reinforce test coverage for shapes

Ref naver#3333
@netil netil mentioned this pull request Aug 28, 2023
Merged
netil added a commit that referenced this pull request Aug 28, 2023
@netil
test(shapes): Add tests for shapes (#3375)
22a77eb 
Reinforce test coverage for shapes

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 28, 2023
test(plugin): Add tests for plugins
01a8e3d 
- Remove duplicated code from stanford plugin
- Reinforce test codes for plugins

Ref naver#3333
@netil netil mentioned this pull request Aug 28, 2023
Merged
netil added a commit that referenced this pull request Aug 28, 2023
@netil
test(plugin): Add tests for plugins (#3376)
72aabde 
- Remove duplicated code from stanford plugin
- Reinforce test codes for plugins

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 28, 2023
test(module): Add test for module
5dc67ff 
- Fix cache remove bug when id is given as string
- Reinforce test for module

Ref naver#3333
@netil netil mentioned this pull request Aug 28, 2023
Merged
netil added a commit that referenced this pull request Aug 28, 2023
@netil
test(module): Add test for module (#3377)
071ef60 
- Fix cache remove bug when id is given as string
- Reinforce test for module

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 29, 2023
test(plugin): Reinforce stanford test
9b79be7 
Add test cases for timeseries and category type axis

Ref naver#3333
netil added a commit that referenced this pull request Aug 29, 2023
@netil
test(plugin): Reinforce stanford test (#3384)
4d3764d 
Add test cases for timeseries and category type axis

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 29, 2023
test(plugin): Add test for stanford & tableview
69b76e9 
Ref naver#3333
@netil netil mentioned this pull request Aug 29, 2023
Merged
netil added a commit that referenced this pull request Aug 29, 2023
@netil
test(plugin): Add test for stanford & tableview (#3385)
715c3d4 
Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 29, 2023
test(module): update test for worker
ea4af92 
- Add conditional for onerror logging
- Update test condition

Ref naver#3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 29, 2023
test(module): update test for worker
aa59885 
- Add conditional for onerror logging
- Update test condition

Ref naver#3333
@netil netil mentioned this pull request Aug 29, 2023
Merged
netil added a commit that referenced this pull request Aug 29, 2023
@netil
test(module): update test for worker (#3386)
3f891b3 
- Add conditional for onerror logging
- Update test condition

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 30, 2023
test(module): Add test for module & category
ddab825 
- update some browser & worker module as function to facilitate test
- add test case for internal/category

Ref naver#3333
@netil netil mentioned this pull request Aug 30, 2023
Merged
netil added a commit that referenced this pull request Aug 30, 2023
@netil
test(module): Add test for module & category (#3390)
3fdc518 
- update some browser & worker module as function to facilitate test
- add test case for internal/category

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 30, 2023
test(module): Update test for browser & worker module
1695428 
Reinforce test codes

Ref naver#3333
@netil netil mentioned this pull request Aug 30, 2023
Merged
netil added a commit that referenced this pull request Aug 30, 2023
@netil
test(module): Update test for browser & worker module (#3391)
17f9f00 
Reinforce test codes

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
@netil
test(plugin): boost test coverage (#3333)
3fe33ae 
- Exclude d3 modules to be transpiled for test build
  (some d3 code block scope, transpile wrongly and throws error)
- Add test codes for plugins
- Include again textoverlap plugin test(fixed and happened due to the transpile issue)
netil added a commit that referenced this pull request Sep 5, 2023
@netil
test(api): Increase test coverage for APIs (#3350)
5d9daa4 
Enforce test coverage under 90%

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
@netil
test(interaction): Increase test coverage for interactions (#3360)
a55105e 
- Reinforce test coverage for interaction related codes
- Remove unused ‘else’ condition block from .generateTicks()
- Remove unused ‘jsonTreemp’ module

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
@netil
test(internals): Add tests for internals code (#3373)
f2565ec 
Reinforce test codes to increase coverage

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
@netil
test(shape): Reinforce test coverage (#3374)
a4611be 
Add test cases for shapes to increase test coverage

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
@netil
test(shapes): Add tests for shapes (#3375)
190193c 
Reinforce test coverage for shapes

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
@netil
test(plugin): Add tests for plugins (#3376)
14146a3 
- Remove duplicated code from stanford plugin
- Reinforce test codes for plugins

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
@netil
test(module): Add test for module (#3377)
df23dd0 
- Fix cache remove bug when id is given as string
- Reinforce test for module

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
@netil
test(plugin): Reinforce stanford test (#3384)
8a50faa 
Add test cases for timeseries and category type axis

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
@netil
test(plugin): Add test for stanford & tableview (#3385)
242cf36 
Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
@netil
test(module): update test for worker (#3386)
0c83222 
- Add conditional for onerror logging
- Update test condition

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
@netil
test(module): Add test for module & category (#3390)
201a8e3 
- update some browser & worker module as function to facilitate test
- add test case for internal/category

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
@netil
test(module): Update test for browser & worker module (#3391)
75a1ad1 
Reinforce test codes

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Sep 13, 2023
test(point): Add custom point test
0104302 
Ref naver#3333
@netil netil mentioned this pull request Sep 13, 2023
Merged
netil added a commit that referenced this pull request Sep 13, 2023
@netil
test(point): Add custom point test (#3423)
20fc229 
Ref #3333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@netil netil

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netil @coveralls