Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(plugin): boost test coverage #3333

Merged
merged 1 commit into from
Aug 10, 2023
Merged

test(plugin): boost test coverage #3333

merged 1 commit into from
Aug 10, 2023

Conversation

netil
Copy link
Member

@netil netil commented Aug 10, 2023

Issue

#3332

Details

  • Exclude d3 modules to be transpiled for test build (some d3 code block scope, transpile wrongly and throws error)
  • Add test codes for plugins
  • Include again textoverlap plugin test(fixed and happened due to the transpile issue)

Result

Plugin test coverage increased:

  • From: 83.72% -> To: 94.25%
image

- Exclude d3 modules to be transpiled for test build
  (some d3 code block scope, transpile wrongly and throws error)
- Add test codes for plugins
- Include again textoverlap plugin test(fixed and happened due to the transpile issue)
@netil netil added the test label Aug 10, 2023
@netil netil self-assigned this Aug 10, 2023
@coveralls
Copy link

Coverage Status

coverage: 91.465% (+0.6%) from 90.859% when pulling fcb4053 on netil:test#3332 into b7ba810 on naver:master.

@netil netil merged commit 32d6d01 into naver:master Aug 10, 2023
5 checks passed
@netil netil deleted the test#3332 branch August 10, 2023 10:13
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 21, 2023
Enforce test coverage under 90%

Ref naver#3333
netil added a commit that referenced this pull request Aug 21, 2023
Enforce test coverage under 90%

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 22, 2023
Enforce test coverage under 90%

Ref naver#3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 22, 2023
- Reinforce test coverage for interaction related codes
- Remove unused ‘else’ condition block from .generateTicks()
- Remove unused ‘jsonTreemp’ module

Ref naver#3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 22, 2023
- Reinforce test coverage for interaction related codes
- Remove unused ‘else’ condition block from .generateTicks()
- Remove unused ‘jsonTreemp’ module

Ref naver#3333
netil added a commit that referenced this pull request Aug 22, 2023
- Reinforce test coverage for interaction related codes
- Remove unused ‘else’ condition block from .generateTicks()
- Remove unused ‘jsonTreemp’ module

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 25, 2023
Reinforce test codees to increase coverage

Ref naver#3333
netil added a commit that referenced this pull request Aug 25, 2023
Reinforce test codes to increase coverage

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 25, 2023
Add test cases for shapes to increase test coverage

Ref naver#3333
netil added a commit that referenced this pull request Aug 25, 2023
Add test cases for shapes to increase test coverage

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 28, 2023
Reinforce test coverage for shapes

Ref naver#3333
netil added a commit that referenced this pull request Aug 28, 2023
Reinforce test coverage for shapes

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 28, 2023
- Remove duplicated code from stanford plugin
- Reinforce test codes for plugins

Ref naver#3333
netil added a commit that referenced this pull request Aug 28, 2023
- Remove duplicated code from stanford plugin
- Reinforce test codes for plugins

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 28, 2023
- Fix cache remove bug when id is given as string
- Reinforce test for module

Ref naver#3333
netil added a commit that referenced this pull request Aug 28, 2023
- Fix cache remove bug when id is given as string
- Reinforce test for module

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 29, 2023
Add test cases for timeseries and category type axis

Ref naver#3333
netil added a commit that referenced this pull request Aug 29, 2023
Add test cases for timeseries and category type axis

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 29, 2023
netil added a commit that referenced this pull request Aug 29, 2023
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 29, 2023
- Add conditional for onerror logging
- Update test condition

Ref naver#3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 29, 2023
- Add conditional for onerror logging
- Update test condition

Ref naver#3333
netil added a commit that referenced this pull request Aug 29, 2023
- Add conditional for onerror logging
- Update test condition

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 30, 2023
- update some browser & worker module as function to facilitate test
- add test case for internal/category

Ref naver#3333
netil added a commit that referenced this pull request Aug 30, 2023
- update some browser & worker module as function to facilitate test
- add test case for internal/category

Ref #3333
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 30, 2023
netil added a commit that referenced this pull request Aug 30, 2023
netil added a commit that referenced this pull request Sep 5, 2023
- Exclude d3 modules to be transpiled for test build
  (some d3 code block scope, transpile wrongly and throws error)
- Add test codes for plugins
- Include again textoverlap plugin test(fixed and happened due to the transpile issue)
netil added a commit that referenced this pull request Sep 5, 2023
Enforce test coverage under 90%

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
- Reinforce test coverage for interaction related codes
- Remove unused ‘else’ condition block from .generateTicks()
- Remove unused ‘jsonTreemp’ module

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
Reinforce test codes to increase coverage

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
Add test cases for shapes to increase test coverage

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
Reinforce test coverage for shapes

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
- Remove duplicated code from stanford plugin
- Reinforce test codes for plugins

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
- Fix cache remove bug when id is given as string
- Reinforce test for module

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
Add test cases for timeseries and category type axis

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
netil added a commit that referenced this pull request Sep 5, 2023
- Add conditional for onerror logging
- Update test condition

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
- update some browser & worker module as function to facilitate test
- add test case for internal/category

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
netil pushed a commit to netil/billboard.js that referenced this pull request Sep 13, 2023
netil added a commit that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants