Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Persist): fix get method for no value #38

Merged
merged 1 commit into from
Apr 2, 2019
Merged

fix(Persist): fix get method for no value #38

merged 1 commit into from
Apr 2, 2019

Conversation

daybrush
Copy link
Member

@daybrush daybrush commented Apr 1, 2019

#37

@daybrush daybrush requested review from jongmoon and WoodNeck April 1, 2019 12:51
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.617% when pulling d1d3a56 on younkue:get into d907f48 on naver:master.

jongmoon
jongmoon approved these changes Apr 2, 2019
View reviewed changes
Copy link

@jongmoon jongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but check indentation

@daybrush daybrush merged commit e0b1ec8 into naver:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jongmoon jongmoon jongmoon approved these changes

@WoodNeck WoodNeck WoodNeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daybrush @coveralls @jongmoon @WoodNeck