Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Darkside] Quality assurance P8 #3536

Merged
merged 17 commits into from
Feb 5, 2025
Merged

[Darkside] Quality assurance P8 #3536

merged 17 commits into from
Feb 5, 2025

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Feb 1, 2025

Description

More small adjustments based on Figma walkthrough.

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

@KenAJoh KenAJoh self-assigned this Feb 1, 2025
Copy link

changeset-bot bot commented Feb 1, 2025

🦋 Changeset detected

Latest commit: ff7a9b0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Storybook demo / Chromatic

b5a7a2d5d | 91 components | 135 stories

Copy link
Contributor

@it-vegard it-vegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@KenAJoh KenAJoh merged commit 8f9f313 into main Feb 5, 2025
6 checks passed
@KenAJoh KenAJoh deleted the darkside-QA-8 branch February 5, 2025 10:24
@github-actions github-actions bot mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants