Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Darkside] MVP documentation for testing #3551

Merged
merged 18 commits into from
Feb 6, 2025
Merged

[Darkside] MVP documentation for testing #3551

merged 18 commits into from
Feb 6, 2025

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Feb 4, 2025

Description

Best read by opening the storybook-preview and seeing the output

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: c5dadae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Storybook demo / Chromatic

07d42cfe5 | 91 components | 135 stories

@KenAJoh KenAJoh merged commit e06f0c6 into main Feb 6, 2025
2 of 4 checks passed
@KenAJoh KenAJoh deleted the docpage-pilots-2 branch February 6, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants