[Darkside] Removed 'base' as neutral role replacement #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook demo / Chromatic📝 Changes to review: 1310e71bf0c8 | 91 components | 135 stories |
KenAJoh
added a commit
that referenced
this pull request
Feb 6, 2025
…3555) * 💄 Update background Header * 💄 Update popover padding for smaller screens * 💄 Adjusted borders * 💄 Uses Alpha-tokens for zebra-stripes in Table * 💄 Stronger border for hovered timeline items, transparent track bg * 💄 Transparent lines for Tabs to contrast colored bg * 💄 New icons for Table-sorting * 💄 Selected exoanded item now has accent colors * 💄 Keeps border-color for active state in search-button * 💄 Removed hover-color change on checked radio * 💄 Only non-responsive or left-static guidepanels shrink on tablet or below * 📝 Changeset * 🚚 -hover tokens are now soft-hover * ✨ Added soft-pressed token * 💄 Use new soft-pressed token where applicable * 💄 Default colored text is now 1000, strong replaced by subtle * 🏷️ Updated primitive types for new text-tokens * 🚚 Migrated old text-role-strong color to text-role-default * 🚚 Migrated referansesider to new text-colors * 🚚 Referansesider uses new soft-hover token * 🐛 Fallback to updated accent-color * [Darkside] Removed 'base' as neutral role replacement (#3556) * ♻️ Remove default-scale as replacement for neutral in config * 🧪 Setup chromatic-run for complete build * 🚚 Text migrated * 🚚 Text icon migrated * 🚚 Text contrast migrated * 🚚 bg soft migrated to neutral * 🚚 bg moderate migrated to neutral * 🚚 bg strong migrated to neutral * 🚚 border default migrated to neutral * 🚚 border subtle migrated to neutral * 🚚 border strong migrated to neutral * ⬅️ Revert chromatic preview * 🚚 Migrated referansesider to new neutral scale
KenAJoh
added a commit
that referenced
this pull request
Feb 6, 2025
* 💄 Update background Header * 💄 Update popover padding for smaller screens * 💄 Adjusted borders * 💄 Uses Alpha-tokens for zebra-stripes in Table * 💄 Stronger border for hovered timeline items, transparent track bg * 💄 Transparent lines for Tabs to contrast colored bg * 💄 New icons for Table-sorting * 💄 Selected exoanded item now has accent colors * 💄 Keeps border-color for active state in search-button * 💄 Removed hover-color change on checked radio * 💄 Only non-responsive or left-static guidepanels shrink on tablet or below * 📝 Changeset * 🚚 -hover tokens are now soft-hover * ✨ Added soft-pressed token * 💄 Use new soft-pressed token where applicable * 💄 Default colored text is now 1000, strong replaced by subtle * 🏷️ Updated primitive types for new text-tokens * 🚚 Migrated old text-role-strong color to text-role-default * 🚚 Migrated referansesider to new text-colors * 🚚 Referansesider uses new soft-hover token * 🐛 Fallback to updated accent-color * [Darkside] Removed 'base' as neutral role replacement (#3556) * ♻️ Remove default-scale as replacement for neutral in config * 🧪 Setup chromatic-run for complete build * 🚚 Text migrated * 🚚 Text icon migrated * 🚚 Text contrast migrated * 🚚 bg soft migrated to neutral * 🚚 bg moderate migrated to neutral * 🚚 bg strong migrated to neutral * 🚚 border default migrated to neutral * 🚚 border subtle migrated to neutral * 🚚 border strong migrated to neutral * ⬅️ Revert chromatic preview * 🚚 Migrated referansesider to new neutral scale * 🚚 Use named brand and meta-colors * 🚚 Referansesider uses new brand-names token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now explicitly require
neutral-role to be used for "neutral"-color tokensComponent Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")