Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endringer på metrics #171

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Endringer på metrics #171

merged 2 commits into from
Feb 11, 2024

Conversation

nils-arne
Copy link
Contributor

No description provided.

@nils-arne nils-arne requested a review from enstulen February 8, 2024 07:36
@nils-arne nils-arne requested a review from a team as a code owner February 8, 2024 07:36
Copy link
Contributor

@enstulen enstulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Histogram
.build()
.namespace(SOKNAD_NAMESPACE)
.name(name)
.help(help)
.buckets(0.1, 0.2, 0.4, 0.8, 1.6, 3.2, 6.4, 12.8, 25.6, 51.2, 100.2)
.buckets(1024.0, 10*1024.0, 50*1024.0, 100*1024.0, 1024*1024.0, 10*1024*1024.0, 50*1024*1024.0, 150*1024*1024.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lag variabel for kb?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kanskje en for 5mb ogg 25mb?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

UUID.randomUUID().toString()
))

CoroutineScope(Dispatchers.Default).launch {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runBlocking

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


val observations = metrics.getJoarkLatency()
assertEquals(latencies.values.sum().toDouble(), observations.count)
assertTrue(observations.quantiles[0.99]!! > 10.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sjekk nøyaktig i stedet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, sjekket at quantile verdier er over et visst nivå

@nils-arne nils-arne merged commit 3a96ec3 into main Feb 11, 2024
10 checks passed
@nils-arne nils-arne deleted the endringer-pa-metrics branch February 11, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants