Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making AbstractSimplesPool more extensible #417

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Making AbstractSimplesPool more extensible #417

merged 1 commit into from
Jul 9, 2024

Conversation

antonioconselheiro
Copy link
Contributor

I wanna extends AbstractSimplesPool to create and test other complementary implementations for my software, It will be so bad to change this to protected? Please 🙏

@antonioconselheiro antonioconselheiro changed the title Making AbstractSimplesPool more extendable Making AbstractSimplesPool more extensible Jul 8, 2024
@fiatjaf fiatjaf merged commit 235a1c5 into nbd-wtf:master Jul 9, 2024
2 checks passed
@fiatjaf
Copy link
Collaborator

fiatjaf commented Jul 9, 2024

I didn't even know this was a thing. Apparently JavaScript is Java now.

@antonioconselheiro
Copy link
Contributor Author

javascript still a wild jungle, typescript is the civilization

@antonioconselheiro antonioconselheiro deleted the abstract-pool-signature branch July 9, 2024 10:42
@fiatjaf
Copy link
Collaborator

fiatjaf commented Jul 9, 2024

TypeScript and JavaScript are the same thing.

@antonioconselheiro
Copy link
Contributor Author

I disagree, javascript drove me crazy, but typescript was very good for my mental health

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants