fix!: handle changed opnsense api since 22.7.x

[jdreffein]

This MR addresses Issue #6 and correctly handles the changed return codes by the api of latest opnsense versions.

It is breaking for users of opnsense prior 22.7.x since there is no version handling by the check.

[nbuchwitz]

Thanks for the MR in this repo too! I will have a look later today, when I have access to my test environment. Maybe we can find a way to check the version and thus make it backward compatible (eg. check if certain attributes are part of the response and parse either this or that in the check)

[nbuchwitz]

I've slightly reworked your patch and rebased it against current master branch (some changes in #10). In my setup everything looks fine. Please test in your setup and if it is also good, I will merge it and publish the v0.2.0 release.

[jdreffein]

i had to make changes to the needs reboot state, which is returned reboot flag in different keys by old and new api versions. in our environment with v 24.1.9 my last commit works as expected.

[nbuchwitz]

I've updated the PR again, after I did some digging into opnsense's API code (https://github.com/opnsense/core/blob/master/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php). Hopefully this should cover everything with recent versions. Happy to hear about your tests!

[jdreffein]

Sorry for the long time off. Just managed to test the code in my fork. It is working with my current version of OPNsense (24.1.10_8)

[koelle25]

Hi. Thanks for your PR, I merged it into my copy of the check script.

But recently I noticed a problem. The returned json contained

"status_msg": "No address record found for the selected mirror.",
"status": "error"

Due to this, the check resulted in

OK: System up to date

To resolve this, I changed line 214 from if data["status"] == "none": to if data['status'] in ('none', 'error'): in order to force a POST request in that case, too.

After that it worked and resulted in

CRITICAL: There are 43 updates available, total download size is 199.1MiB. This update requires a reboot.

as I expected it to (as the OPNsense WebGUI also showed these).

[nbuchwitz]

Thanks for the hint. I've added it to Jörgs original commit, so we can get this merged.