Seek to time in video feature. and duration returning on video closed #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think if we can get an iOS implementation in addition this would be a great addition. |
|
iOS implementation added as a PR on praveenpl03's fork |
|
Great job sir .. any thing i can do please let me know.
…On Mon, 6 Sep, 2021, 12:13 am Jerod Fritz, ***@***.***> wrote:
iOS implementation added as a PR on praveenpl03's fork
<praveenpl03#1>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#222 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQFDAKL3M5XK2662DOO5TX3UAO237ANCNFSM4533725Q>
.
|
|
You can merge my PR in your repo so that it is included in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a small feature that allows seeking time in the video and return duration on video closed.
Can use "start": "19989" in options to seek to this time on video
Added Returning JSON on success or error callback
Having
{
"duration":"12130",// in miliseconds
"message":"Error Message" // if available
}