Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate "parseOSD" functions into create_OSD #29

Merged
merged 5 commits into from
Jul 8, 2021
Merged

Integrate "parseOSD" functions into create_OSD #29

merged 5 commits into from
Jul 8, 2021

Conversation

brownag
Copy link
Member

@brownag brownag commented Jul 3, 2021

This integrates OSD site and horizon data frames as additional results in the main JSON product of create_OSD (in /inst/extdata/OSD/.../SERIES.json)

Addresses several items for #25

  • converts most external dependencies to base; add several {stringi} methods to SoilKnowledgeBase namespace
  • adapts TYPICAL PEDON parsing code to use JSON representation of OSDs
  • several TODO items resolved, some new ones created and structures for further extension

brownag
brownag commented Jul 3, 2021
View reviewed changes
Copy link
Member Author

@brownag brownag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to be working as expected!

@brownag brownag marked this pull request as ready for review July 3, 2021 05:37
@brownag brownag merged commit 9e29eef into main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brownag