Implement data.table checkHzDepthLogic RE #157, #174 #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brownag
changed the title
brownag
changed the title
brownag
added a commit
that referenced
this pull request
Jan 21, 2021
brownag
added a commit
that referenced
this pull request
Jan 21, 2021
…est changes" This reverts commit f63d623.
dylanbeaudette
approved these changes
Jan 21, 2021
|
See #174 for the benchmarks -- it is ~5-10x faster |
|
Sorry, mis-read my own bench mark. Raw data.table is >50x faster in my benchmark. But there is some overhead from the way the function is set up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses my first demonstration point from #174
RE: #174 I am thinking that full generalization of
profileApplyis not worth it -- I have some ideas onmutate_profile. That should perhaps be spliced off into a new, back-burner issue.